Optimize the use of xml_parent() vs. xml_find_all("parent::*")#3011
Open
MichaelChirico wants to merge 3 commits intomainfrom
Open
Optimize the use of xml_parent() vs. xml_find_all("parent::*")#3011MichaelChirico wants to merge 3 commits intomainfrom
MichaelChirico wants to merge 3 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3011 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 128 128
Lines 7288 7290 +2
=======================================
+ Hits 7232 7234 +2
Misses 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2497. Written with Gemini. The results were pretty strongly against using
xml_parent()for "typical" expressions {lintr} will encounter, so I also went ahead and refactored existing usages into XPath equivalents.I've folded a summary of the dialog and a few full benchmarking scripts in
Detailsbelow.Details
Digest of Gemini dialog
For R/source_utils.R
For R/duplicate_argument_linter.R
For R/implicit_integer_linter.R